Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/entityanalytics/provider/okta/internal/okta: new package #35478

Merged
merged 1 commit into from
Jun 6, 2023
Merged

x-pack/filebeat/input/entityanalytics/provider/okta/internal/okta: new package #35478

merged 1 commit into from
Jun 6, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 16, 2023 •
edited
Loading

What does this PR do?

This adds a new package for accessing the Okta user API.

Why is it important?

It is necessary for adding the Okta entity analytics input.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Obtain an Okta dev account and set up an auth token, then you can run the tests in x-pack/filebeat/input/entityanalytics/provider/okta/internal/okta with

OKTA_HOST=<oktadomain> OKTA_TOKEN=<token> go test -v -log_user_response

Related issues

  • For elastic/security-team#5100

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify 8.9-candidate labels May 16, 2023
@efd6 efd6 self-assigned this May 16, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 16, 2023
@efd6 efd6 marked this pull request as ready for review May 16, 2023 09:20
@efd6 efd6 requested a review from a team as a code owner May 16, 2023 09:20
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 16, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-05T23:13:59.647+0000

  • Duration: 74 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 2963
Skipped 175
Total 3138

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 16, 2023
@jamiehynds
Copy link

@taylor-swanson would you mind reviewing this one? Dan has added support for Okta users to the input, and Crest hoping to start on the package itself once we get this PR reviewed & merged.

@efd6
Copy link
Contributor Author

efd6 commented May 29, 2023

@jamiehynds This is the first half, the actual input will build on this.

@efd6 efd6 force-pushed the 5100-okta-api branch 4 times, most recently from 40f618b to 757f94b Compare May 30, 2023 02:24
@efd6 efd6 mentioned this pull request May 30, 2023
Merged
6 tasks
@efd6 efd6 force-pushed the 5100-okta-api branch 2 times, most recently from cc0a21d to 6818ea8 Compare June 2, 2023 01:27
@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 5100-okta-api upstream/5100-okta-api
git merge upstream/main
git push upstream 5100-okta-api

taylor-swanson
taylor-swanson approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great! Aside from a minor comment and fixing the linter issues, LGTM.

x-pack/filebeat/input/entityanalytics/provider/okta/internal/okta/okta.go Show resolved Hide resolved
@efd6 efd6 merged commit 76fae6b into elastic:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylor-swanson taylor-swanson taylor-swanson approved these changes

Assignees

@efd6 efd6

Labels
8.9-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efd6 @elasticmachine @jamiehynds @taylor-swanson